-
Notifications
You must be signed in to change notification settings - Fork 37
get data from meta leader #310
get data from meta leader #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Raft support major peer consistent to make all peer hold the same data why read different peer could found different value ? |
Raft only make major consistent, I think so. |
Good job. Since there are more work than this, for example, we don't need sync anymore, ActiveHostMan and LastUpdateTimeMan perhaps need to change as well. Would you move this PR to 1.0 as well, let me handle 2.0 later. |
yep vote should more than half |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Maybe we could remove the toLeader
option and I don't think we need the inconsistent meta data that different from data itself.
For some reasons, the data read from different copies of meta data may be inconsistent.
Therefore, we uniformly obtain data from the leader.