Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

get data from meta leader #310

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

panda-sheep
Copy link
Contributor

For some reasons, the data read from different copies of meta data may be inconsistent.
Therefore, we uniformly obtain data from the leader.

@panda-sheep panda-sheep added ready-for-review ready-for-testing PR: ready for the CI test labels Nov 18, 2020
Copy link
Contributor

@liuyu85cn liuyu85cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darionyaphet
Copy link
Contributor

darionyaphet commented Nov 18, 2020

Raft support major peer consistent to make all peer hold the same data why read different peer could found different value ?

@Shylock-Hg
Copy link
Contributor

Raft support strong consistent to make all peer hold the same data why read different peer could found different value ?

Raft only make major consistent, I think so.

@critical27
Copy link
Contributor

critical27 commented Nov 18, 2020

Good job. Since there are more work than this, for example, we don't need sync anymore, ActiveHostMan and LastUpdateTimeMan perhaps need to change as well. Would you move this PR to 1.0 as well, let me handle 2.0 later.

@darionyaphet
Copy link
Contributor

Raft support strong consistent to make all peer hold the same data why read different peer could found different value ?

Raft only make major consistent, I think so.

yep vote should more than half

Copy link
Contributor

@Shylock-Hg Shylock-Hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Maybe we could remove the toLeader option and I don't think we need the inconsistent meta data that different from data itself.

@critical27 critical27 merged commit 9feb106 into vesoft-inc:master Dec 10, 2020
@panda-sheep panda-sheep deleted the meta_get_data_from_leader branch December 10, 2020 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants