-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timezone conversion. #37
Add timezone conversion. #37
Conversation
@@ -48,4 +50,17 @@ void Session::release() { | |||
} | |||
} | |||
|
|||
void Session::toLocal(DataSet &data, int32_t offsetSecs) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to provide a method like that, but you can tell user how to get localTime and get localDateTime in example code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface better move to test code, no need to provide it to the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User could use or not.
…ebula-cpp into feature/timezone-conversion
…ebula-cpp into feature/timezone-conversion
Please fix the ci test |
Require vesoft-inc/nebula-common#571