Add full index scan rules into default ruleset in optimizer (#1205)

src/optimizer/OptimizerUtils.cpp

@@ -856,6 +856,7 @@ bool OptimizerUtils::findOptimalIndex(const Expression* condition,
         }
         break;
     }
+    // The filter can always be pushed down for lookup query
     if (iter != index.hints.end() || !index.unusedExprs.empty()) {
         ictx->set_filter(condition->encode());
     }

src/optimizer/rule/EdgeIndexFullScanRule.cpp

@@ -21,7 +21,7 @@ std::unique_ptr<OptRule> EdgeIndexFullScanRule::kInstance =
     std::unique_ptr<EdgeIndexFullScanRule>(new EdgeIndexFullScanRule());
 
 EdgeIndexFullScanRule::EdgeIndexFullScanRule() {
-    RuleSet::QueryRules().addRule(this);
+    RuleSet::DefaultRules().addRule(this);
 }
 
 const Pattern& EdgeIndexFullScanRule::pattern() const {

src/optimizer/rule/PushFilterDownEdgeIndexScanRule.cpp

@@ -46,7 +46,7 @@ std::unique_ptr<OptRule> PushFilterDownEdgeIndexScanRule::kInstance =
     std::unique_ptr<PushFilterDownEdgeIndexScanRule>(new PushFilterDownEdgeIndexScanRule());
 
 PushFilterDownEdgeIndexScanRule::PushFilterDownEdgeIndexScanRule() {
-    RuleSet::QueryRules().addRule(this);
+    RuleSet::DefaultRules().addRule(this);
 }
 
 const Pattern& PushFilterDownEdgeIndexScanRule::pattern() const {

src/optimizer/rule/PushFilterDownEdgeIndexScanRule.h

@@ -14,6 +14,9 @@
 namespace nebula {
 namespace opt {
 
+// At present, we do NOT split filter conditions into two parts, one part is pushed down storage
+// layer and another will be leaved into filter. Because this is enough for Lookup queries. We
+// will enhance this rule for general usage later, such as MATCH queries.
 class PushFilterDownEdgeIndexScanRule final : public OptRule {
 public:
     const Pattern &pattern() const override;

src/optimizer/rule/PushFilterDownTagIndexScanRule.cpp

@@ -37,7 +37,7 @@ std::unique_ptr<OptRule> PushFilterDownTagIndexScanRule::kInstance =
     std::unique_ptr<PushFilterDownTagIndexScanRule>(new PushFilterDownTagIndexScanRule());
 
 PushFilterDownTagIndexScanRule::PushFilterDownTagIndexScanRule() {
-    RuleSet::QueryRules().addRule(this);
+    RuleSet::DefaultRules().addRule(this);
 }
 
 const Pattern& PushFilterDownTagIndexScanRule::pattern() const {

src/optimizer/rule/PushFilterDownTagIndexScanRule.h

@@ -14,6 +14,9 @@
 namespace nebula {
 namespace opt {
 
+// At present, we do NOT split filter conditions into two parts, one part is pushed down storage
+// layer and another will be leaved into filter. Because this is enough for Lookup queries. We
+// will enhance this rule for general usage later, such as MATCH queries.
 class PushFilterDownTagIndexScanRule final : public OptRule {
 public:
     const Pattern &pattern() const override;

src/optimizer/rule/TagIndexFullScanRule.cpp

@@ -17,7 +17,7 @@ std::unique_ptr<OptRule> TagIndexFullScanRule::kInstance =
     std::unique_ptr<TagIndexFullScanRule>(new TagIndexFullScanRule());
 
 TagIndexFullScanRule::TagIndexFullScanRule() {
-    RuleSet::QueryRules().addRule(this);
+    RuleSet::DefaultRules().addRule(this);
 }
 
 const Pattern& TagIndexFullScanRule::pattern() const {

src/optimizer/rule/UnionAllEdgeIndexScanRule.cpp

@@ -15,7 +15,7 @@ std::unique_ptr<OptRule> UnionAllEdgeIndexScanRule::kInstance =
     std::unique_ptr<UnionAllEdgeIndexScanRule>(new UnionAllEdgeIndexScanRule());
 
 UnionAllEdgeIndexScanRule::UnionAllEdgeIndexScanRule() {
-    RuleSet::QueryRules().addRule(this);
+    RuleSet::DefaultRules().addRule(this);
 }
 
 const Pattern& UnionAllEdgeIndexScanRule::pattern() const {

src/optimizer/rule/UnionAllTagIndexScanRule.cpp

@@ -15,7 +15,7 @@ std::unique_ptr<OptRule> UnionAllTagIndexScanRule::kInstance =
     std::unique_ptr<UnionAllTagIndexScanRule>(new UnionAllTagIndexScanRule());
 
 UnionAllTagIndexScanRule::UnionAllTagIndexScanRule() {
-    RuleSet::QueryRules().addRule(this);
+    RuleSet::DefaultRules().addRule(this);
 }
 
 const Pattern& UnionAllTagIndexScanRule::pattern() const {