Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

fix #1012: Collect values from InputExpression crash the nebula graphd #1015

Merged
merged 1 commit into from
May 10, 2021
Merged

fix #1012: Collect values from InputExpression crash the nebula graphd #1015

merged 1 commit into from
May 10, 2021

Conversation

jievince
Copy link
Contributor

fix #1012

We don't need to pass a needVisitedTypes to agg rewriter because the expression kinds that don't need to be visited have an empty function of body implementation.

 void visit(ConstantExpression *) override {}
 void visit(LabelExpression*) override {}
 ...

Expression kinds such as kConstant, kLabelProperty are basic kinds, they are impossible to nest an agg

@jievince jievince added the ready-for-testing PR: ready for the CI test label May 10, 2021
@jievince jievince requested a review from a team May 10, 2021 03:29
yixinglu
yixinglu approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 52a397c into vesoft-inc:master May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@czpmango czpmango czpmango approved these changes

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@laura-ding laura-ding Awaiting requested review from laura-ding

@Shylock-Hg Shylock-Hg Awaiting requested review from Shylock-Hg

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect values from InputExpression crash the nebula graphd
3 participants
@jievince @yixinglu @czpmango