This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
refactor unwind #1018
Merged
refactor unwind #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
added
ready-for-testing
czpmango
force-pushed
the
refactor-unwind
branch
4 times, most recently
from
3d8792c
to
bbbf41a
Compare
czpmango
force-pushed
the
refactor-unwind
branch
2 times, most recently
from
d17d726
to
fbb89aa
Compare
Shylock-Hg
reviewed
May 12, 2021
| @@ -97,119 +97,6 @@ Feature: With clause and Unwind clause | |||
| | age | | |||
| | 23 | | |||
|
|
|||
| Scenario: unwind return | |||
There was a problem hiding this comment.
Moved to Unwind.feature
Shylock-Hg
reviewed
May 12, 2021
|
|
||
| auto iter = ectx_->getResult(unwind->inputVar()).iter(); | ||
| DCHECK(!!iter); | ||
| auto &inputRes = ectx_->getResult(unwind->inputVar()); |
There was a problem hiding this comment.
What's the improvement?
There was a problem hiding this comment.
Removed a inner for-block to avoid expression overhead.
Shylock-Hg
reviewed
May 12, 2021
yixinglu
approved these changes
May 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactored the implementation of unwind, and did the following things: