Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

add gflags to switch octal escape char support #1079

Merged
merged 14 commits into from
Jun 30, 2021

Conversation

czpmango
Copy link
Contributor

Fixes #1033

@czpmango czpmango requested review from dutor, CPWstatic, a team and Aiee and removed request for dutor May 26, 2021 08:12
@czpmango czpmango added the ready-for-testing PR: ready for the CI test label May 26, 2021
@czpmango czpmango force-pushed the OctEscChar branch 2 times, most recently from 6078f89 to e683555 Compare May 26, 2021 08:38
Aiee
Aiee previously approved these changes May 26, 2021
src/parser/scanner.lex Outdated Show resolved Hide resolved
nevermore3
nevermore3 previously approved these changes May 31, 2021
jievince
jievince previously approved these changes May 31, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some cases to test this bugfix?

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2021

CLA assistant check
All committers have signed the CLA.

@czpmango czpmango added the bug Type: something is unexpected label Jun 23, 2021
@CPWstatic CPWstatic merged commit 8b3abc8 into vesoft-inc:master Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Type: something is unexpected ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insert string bug
7 participants