Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ssl #294

Merged
merged 1 commit into from
Oct 9, 2023
Merged

feat: support ssl #294

merged 1 commit into from
Oct 9, 2023

Conversation

veezhang
Copy link
Contributor

@veezhang veezhang commented Oct 9, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#295

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (1cbec84) 87.89% compared to head (b60aa41) 87.37%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   87.89%   87.37%   -0.52%     
==========================================
  Files          79       79              
  Lines        3857     3906      +49     
==========================================
+ Hits         3390     3413      +23     
- Misses        458      482      +24     
- Partials        9       11       +2     
Files Coverage Δ
pkg/client/option.go 100.00% <100.00%> (ø)
pkg/client/session_v3.go 100.00% <100.00%> (ø)
pkg/config/base/log.go 100.00% <100.00%> (ø)
pkg/config/v3/config.go 86.36% <0.00%> (-4.12%) ⬇️
pkg/config/base/client.go 62.90% <43.90%> (-37.10%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veezhang veezhang added the doc affected PR: improvements or additions to documentation label Oct 9, 2023
@veezhang veezhang requested a review from kqzh October 9, 2023 09:21
Copy link

@kqzh kqzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veezhang veezhang merged commit e0d8be4 into vesoft-inc:master Oct 9, 2023
2 checks passed
@veezhang veezhang mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants