Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version validation #88

Merged
merged 4 commits into from
Mar 7, 2023
Merged

fix version validation #88

merged 4 commits into from
Mar 7, 2023

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Mar 7, 2023

fix some validation and assertion

README_CN.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.04 🎉

Comparison is base (f904dee) 31.29% compared to head (dcafac4) 31.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
+ Coverage     31.29%   31.33%   +0.04%     
  Complexity       78       78              
============================================
  Files            30       30              
  Lines          1518     1519       +1     
  Branches        239      239              
============================================
+ Hits            475      476       +1     
  Misses          973      973              
  Partials         70       70              
Impacted Files Coverage Δ
.../vesoft/nebula/connector/utils/SparkValidate.scala 0.00% <0.00%> (ø)
...ala/com/vesoft/nebula/connector/NebulaConfig.scala 59.00% <50.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, thanks!

@Nicole00 Nicole00 merged commit 06e8900 into vesoft-inc:master Mar 7, 2023
@Nicole00 Nicole00 deleted the assert branch March 7, 2023 08:32
@Nicole00 Nicole00 added the doc affected PR: improvements or additions to documentation label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants