update doc to v3.1.0 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaByte875
reviewed
Apr 25, 2022
README-CN.md
Outdated
| @@ -10,9 +10,11 @@ | |||
|
|
|||
| 一些收集的 metrics 是： | |||
MegaByte875
reviewed
Apr 25, 2022
| @@ -69,12 +71,12 @@ scrape_configs: | |||
| ```shell | |||
| $ docker run -d --restart=always --name nebula-stats-exporter -p 9100:9100 \ | |||
| -v "<<PATH_OF_CONFIG_FILE>>:/config.yaml" \ | |||
| vesoft/nebula-stats-exporter:v0.0.6 --bare-metal --bare-metal-config=/config.yaml | |||
| vesoft/nebula-stats-exporter:v3.1.0 --bare-metal --bare-metal-config=/config.yaml | |||
There was a problem hiding this comment.
use kernel release version?
There was a problem hiding this comment.
yes, because release-tag will use v3.1.0, I think unite is better
There was a problem hiding this comment.
Is the version definition strictly consistent, or just the first two?
For examples,
- nebula release v3.1.0
- stats release v3.1.0
- you find bug in stats, then stats release v3.1.1
- nebula release v3.1.1
So what version is the stats?
There was a problem hiding this comment.
if stats don't have change, stats release v3.1.1, otherwise v3.1.2, promise x.y compatible nebula
MegaByte875
reviewed
Apr 25, 2022
| @@ -22,4 +22,4 @@ maintainers: | |||
| name: nebula-exporter | |||
| sources: | |||
| - https://github.com/vesoft-inc/nebula | |||
| version: 0.0.6 | |||
| version: 3.1.0 | |||
veezhang
approved these changes
Apr 25, 2022
| @@ -69,12 +71,12 @@ scrape_configs: | |||
| ```shell | |||
| $ docker run -d --restart=always --name nebula-stats-exporter -p 9100:9100 \ | |||
| -v "<<PATH_OF_CONFIG_FILE>>:/config.yaml" \ | |||
| vesoft/nebula-stats-exporter:v0.0.6 --bare-metal --bare-metal-config=/config.yaml | |||
| vesoft/nebula-stats-exporter:v3.1.0 --bare-metal --bare-metal-config=/config.yaml | |||
There was a problem hiding this comment.
Is the version definition strictly consistent, or just the first two?
For examples,
- nebula release v3.1.0
- stats release v3.1.0
- you find bug in stats, then stats release v3.1.1
- nebula release v3.1.1
So what version is the stats?
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.