This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Support specified columns for full-text index #460
Merged
bright-starry-sky
merged 2 commits into
vesoft-inc:master
from
bright-starry-sky:fulltext_advance
May 26, 2021
Merged
Support specified columns for full-text index #460
bright-starry-sky
merged 2 commits into
vesoft-inc:master
from
bright-starry-sky:fulltext_advance
May 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bright-starry-sky
added
wip
Solution: work in progress
depend on common
PR: this PR depends on PRs in the common repo
labels
May 13, 2021
bright-starry-sky
force-pushed
the
fulltext_advance
branch
2 times, most recently
from
May 17, 2021 12:04
5dcd4ef
to
286970e
Compare
bright-starry-sky
requested review from
a team
and removed request for
panda-sheep
May 17, 2021 12:28
bright-starry-sky
added
ready-for-testing
PR: ready for the CI test
and removed
wip
Solution: work in progress
labels
May 17, 2021
Ready to review. |
critical27
reviewed
May 18, 2021
critical27
previously approved these changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job
panda-sheep
reviewed
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
bright-starry-sky
force-pushed
the
fulltext_advance
branch
from
May 25, 2021 08:12
286970e
to
6b6cbd6
Compare
critical27
approved these changes
May 25, 2021
panda-sheep
approved these changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
ASAN error occur. in order not to affect the overall compilation , let merge this PR and address the ASAN error immediate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
depend on common
PR: this PR depends on PRs in the common repo
ready-for-testing
PR: ready for the CI test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, Changed full-text index structure, deleted field schema_id
2, Support for creating full-text index against fields
3, Support drop full-text index
4, Support show full-text index
5, Refuse to create full-text index if fixed_string type length > 256
6, Refuse to drop or alter tag if full-text index exists.
depends on vesoft-inc/nebula-common#530