Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Support specified columns for full-text index #460

Merged

Conversation

bright-starry-sky
Copy link
Contributor

@bright-starry-sky bright-starry-sky commented May 13, 2021

1, Changed full-text index structure, deleted field schema_id
2, Support for creating full-text index against fields
3, Support drop full-text index
4, Support show full-text index
5, Refuse to create full-text index if fixed_string type length > 256
6, Refuse to drop or alter tag if full-text index exists.

depends on vesoft-inc/nebula-common#530

@bright-starry-sky bright-starry-sky added wip Solution: work in progress depend on common PR: this PR depends on PRs in the common repo labels May 13, 2021
@bright-starry-sky bright-starry-sky force-pushed the fulltext_advance branch 2 times, most recently from 5dcd4ef to 286970e Compare May 17, 2021 12:04
@bright-starry-sky bright-starry-sky requested review from a team and removed request for panda-sheep May 17, 2021 12:28
@bright-starry-sky bright-starry-sky added ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels May 17, 2021
@bright-starry-sky
Copy link
Contributor Author

Ready to review.

critical27
critical27 previously approved these changes May 25, 2021
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@bright-starry-sky
Copy link
Contributor Author

ASAN error occur. in order not to affect the overall compilation , let merge this PR and address the ASAN error immediate.

@bright-starry-sky bright-starry-sky merged commit cd85c2d into vesoft-inc:master May 26, 2021
@bright-starry-sky bright-starry-sky deleted the fulltext_advance branch July 21, 2021 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
depend on common PR: this PR depends on PRs in the common repo ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants