Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

rebuild fulltext indexes via listener #482

Merged

Conversation

bright-starry-sky
Copy link
Contributor

No description provided.

src/kvstore/Listener.cpp Outdated Show resolved Hide resolved
src/kvstore/Listener.cpp Show resolved Hide resolved
src/meta/processors/jobMan/MetaJobExecutor.cpp Outdated Show resolved Hide resolved
src/kvstore/Listener.cpp Outdated Show resolved Hide resolved
src/kvstore/Listener.cpp Outdated Show resolved Hide resolved
@bright-starry-sky bright-starry-sky force-pushed the fulltext_rebuild branch 3 times, most recently from fcfd64d to 5a3a3c3 Compare June 16, 2021 11:29
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2021

CLA assistant check
All committers have signed the CLA.

@bright-starry-sky
Copy link
Contributor Author

depend on :
vesoft-inc/nebula-common#562

@critical27
Copy link
Contributor

The branch push some weird commit, you may misuse the branch.

@bright-starry-sky
Copy link
Contributor Author

The branch push some weird commit, you may misuse the branch.

Good catch!
yes, the branches are messed up.
fixed. thanks.

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, consider add a test case in NebulaListenerTest to test the snapshot, maybe need to set the size of wal_file and wal_ttl to be very small.

@bright-starry-sky
Copy link
Contributor Author

Generally LGTM, consider add a test case in NebulaListenerTest to test the snapshot, maybe need to set the size of wal_file and wal_ttl to be very small.

Yes, the snapshot test case should have been added a long time ago (since PR #465 submitted), for clarity, let me add it in the new PR. please wait a moment.

critical27
critical27 previously approved these changes Jun 28, 2021
@critical27
Copy link
Contributor

Generally LGTM, consider add a test case in NebulaListenerTest to test the snapshot, maybe need to set the size of wal_file and wal_ttl to be very small.

Yes, the snapshot test case should have been added a long time ago (since PR #465 submitted), for clarity, let me add it in the new PR. please wait a moment.

ok

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Jul 2, 2021
@yixinglu yixinglu requested a review from panda-sheep July 2, 2021 07:04
panda-sheep
panda-sheep previously approved these changes Jul 2, 2021
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@bright-starry-sky
Copy link
Contributor Author

fixed compiler warning for centos7, gcc-9.2

[ 29%] Building CXX object src/storage/CMakeFiles/storage_admin_service_handler.dir/admin/ListClusterInfoProcessor.cpp.o
/__w/nebula-storage/nebula-storage/src/storage/admin/RebuildFTIndexTask.cpp: In member function 'virtual nebula::ErrorOr<nebula::cpp2::ErrorCode, std::vector<nebula::storage::AdminSubTask> > nebula::storage::RebuildFTIndexTask::genSubTasks()':
/__w/nebula-storage/nebula-storage/src/storage/admin/RebuildFTIndexTask.cpp:27:36: error: 'listener' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   27 |         nebula::kvstore::Listener *listener;
      |                                    ^~~~~~~~
cc1plus: all warnings being treated as errors
gmake[2]: *** [src/storage/CMakeFiles/storage_admin_service_handler.dir/admin/RebuildFTIndexTask.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....

@bright-starry-sky bright-starry-sky merged commit 3e80ad7 into vesoft-inc:master Jul 2, 2021
@bright-starry-sky bright-starry-sky deleted the fulltext_rebuild branch July 2, 2021 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants