This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
CreateBackup: backup IncrementalId as well #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkensphere201
requested review from
a team,
bright-starry-sky,
cangfengzhs,
critical27,
liuyu85cn and
panda-sheep
bright-starry-sky
previously approved these changes
Jul 14, 2021
panda-sheep
previously approved these changes
Jul 14, 2021
liuyu85cn
reviewed
Jul 14, 2021
| @@ -155,7 +155,7 @@ ErrorOr<nebula::cpp2::ErrorCode, std::vector<HostAddr>> BaseProcessor<RESP>::all | |||
| template<typename RESP> | |||
| ErrorOr<nebula::cpp2::ErrorCode, int32_t> BaseProcessor<RESP>::autoIncrementId() { | |||
| folly::SharedMutex::WriteHolder holder(LockUtils::idLock()); | |||
| static const std::string kIdKey = "__id__"; | |||
| static const std::string kIdKey = MetaServiceUtils::idKey(); | |||
There was a problem hiding this comment.
What if that static map is not initialized at this time ? I mean I've heard that C++ not guarantee the sequence of two static.
There was a problem hiding this comment.
great catch. it looks like a problem. removed static here. I think the RVO would take place.
linkensphere201
dismissed stale reviews from critical27, panda-sheep, and bright-starry-sky
via
9c35b4f
critical27
approved these changes
Jul 15, 2021
bright-starry-sky
approved these changes
Jul 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled, backup the missed IncrementalID for meta service.