fix_startup_service_failed_when_log_directory_not_exists_and_enable_b…

…reakPad
vesoft-inc · Sep 6, 2022 · bf024e4 · bf024e4
1 parent bcab2f3
commit bf024e4
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 20 deletions.
diff --git a/src/daemons/MetaDaemon.cpp b/src/daemons/MetaDaemon.cpp
@@ -68,14 +68,6 @@ int main(int argc, char* argv[]) {
 
   Status status;
 
-#if defined(ENABLE_BREAKPAD)
-  status = setupBreakpad();
-  if (!status.ok()) {
-    LOG(ERROR) << status;
-    return EXIT_FAILURE;
-  }
-#endif
-
   auto pidPath = FLAGS_pid_file;
   status = ProcessUtils::isPidAvailable(pidPath);
   if (!status.ok()) {
@@ -92,18 +84,26 @@ int main(int argc, char* argv[]) {
     return EXIT_FAILURE;
   }
 
+  // Setup logging
+  status = setupLogging(argv[0]);
+  if (!status.ok()) {
+    LOG(ERROR) << status;
+    return EXIT_FAILURE;
+  }
+
   if (FLAGS_daemonize) {
     google::SetStderrLogging(google::FATAL);
   } else {
     google::SetStderrLogging(google::INFO);
   }
 
-  // Setup logging
-  status = setupLogging(argv[0]);
+#if defined(ENABLE_BREAKPAD)
+  status = setupBreakpad();
   if (!status.ok()) {
     LOG(ERROR) << status;
     return EXIT_FAILURE;
   }
+#endif
 
   // Init stats
   nebula::initMetaStats();

diff --git a/src/daemons/StorageDaemon.cpp b/src/daemons/StorageDaemon.cpp
@@ -61,14 +61,6 @@ int main(int argc, char *argv[]) {
 
   Status status;
 
-#if defined(ENABLE_BREAKPAD)
-  status = setupBreakpad();
-  if (!status.ok()) {
-    LOG(ERROR) << status;
-    return EXIT_FAILURE;
-  }
-#endif
-
   auto pidPath = FLAGS_pid_file;
   status = ProcessUtils::isPidAvailable(pidPath);
   if (!status.ok()) {
@@ -80,18 +72,27 @@ int main(int argc, char *argv[]) {
   if (FLAGS_enable_ssl || FLAGS_enable_meta_ssl) {
     folly::ssl::init();
   }
+
+  // Setup logging
+  status = setupLogging(argv[0]);
+  if (!status.ok()) {
+    LOG(ERROR) << status;
+    return EXIT_FAILURE;
+  }
+
   if (FLAGS_daemonize) {
     google::SetStderrLogging(google::FATAL);
   } else {
     google::SetStderrLogging(google::INFO);
   }
 
-  // Setup logging
-  status = setupLogging(argv[0]);
+#if defined(ENABLE_BREAKPAD)
+  status = setupBreakpad();
   if (!status.ok()) {
     LOG(ERROR) << status;
     return EXIT_FAILURE;
   }
+#endif
 
   // Init stats
   nebula::initStorageStats();