Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate configuration flag for balance, toss etc #4729

Closed
wey-gu opened this issue Oct 14, 2022 · 2 comments
Closed

Use separate configuration flag for balance, toss etc #4729

wey-gu opened this issue Oct 14, 2022 · 2 comments
Labels
type/feature req Type: feature request

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Oct 14, 2022

Is your feature request related to a problem? Please describe.

This will enable the user to use balance without toss or vice versa.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@wey-gu wey-gu added the type/feature req Type: feature request label Oct 14, 2022
@wey-gu
Copy link
Contributor Author

wey-gu commented Oct 15, 2022 •
edited
Loading

cc @MuYiYong

This was referenced Oct 15, 2022
Merged
Closed
@wey-gu
Copy link
Contributor Author

wey-gu commented Oct 17, 2022

close as fixed by @SuperYoko

@wey-gu wey-gu closed this as completed Oct 17, 2022
This was referenced Oct 22, 2022
Closed
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @SuperYoko
split experimental_feature flag (vesoft-inc#1429)
e1baf18 
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

## What type of PR is this?
- [ ] bug
- [ ] feature
- [x] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 

vesoft-inc#4729

#### Description:

experimental flags control toss and data balance at the same time.


## How do you solve it?

add 2 sub flag, current config only allow data balance.

```
# if use experimental features
--enable_experimental_feature=false
# if use toss feature, only work if enable_experimental_feature is true
--enable_toss=false
# if use balance data feature, only work if enable_experimental_feature is true
--enable_data_balance=true
```

## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [x] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> add new flag to support only open toss（not suggest）/ data balance feature

Migrated from vesoft-inc#4728

Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature req Type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wey-gu