Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete tag #2520

Merged
merged 3 commits into from
Aug 17, 2021
Merged

delete tag #2520

merged 3 commits into from
Aug 17, 2021

Conversation

critical27
Copy link
Contributor

common/storage code has been merged before.

Supported syntax:

# single tag
DELETE TAG t1 FROM "a";
# multiple tag
DELETE TAG t1,t2 FROM"a" ;
# all tag
DELETE TAG * FROM "a";
# delete multiple vertices's tag 
DELETE TAG t1 FROM "a", "b";

Pipe and var is supported as well.

@critical27 critical27 added ready-for-testing PR: ready for the CI test doc affected PR: improvements or additions to documentation labels Aug 13, 2021
@critical27 critical27 requested review from a team August 13, 2021 10:52
@critical27 critical27 merged commit 1213ce4 into vesoft-inc:master Aug 17, 2021
@critical27 critical27 deleted the delete branch August 17, 2021 08:40
@jamieliu1023 jamieliu1023 mentioned this pull request Aug 21, 2021
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@nebula-bots @xtcyclist
Fix ExtractFilterExprVisitor. (vesoft-inc#2520)
c9863ca 
* Fix ExtractFilterExprVisitor.

* add tck.

* remove an DCHECK. it is not needed. although the binary operations that it is guarding are suppoed to work only on more than 1 operand, they can and they are, de facto, used to process expressions with only one operand.

Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

@cangfengzhs cangfengzhs Awaiting requested review from cangfengzhs

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

@panda-sheep panda-sheep Awaiting requested review from panda-sheep

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@critical27 @yixinglu @bright-starry-sky