Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a script to do metad folder scp #2532

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Aug 18, 2021

In our forum, some user complain lack of mete transfer tools.

this tool is a simple wrapper to scp to copy local folder of metad to another (remote)place
it afford 4 options:
1. -f (from) local metad dir
2. -t (to) remote destination
3. -u (update) any configs need to be changed
different configs should be seperated by ':'
each config has to be the form of "local_ip=172.0.0.1"

for example

 ./meta-transfer-tools.sh -f /path-to-src/metad1 -t bob@172.0.0.1:/path-to-dst -u local_ip=172.0.0.1:port=10086

this is not a well discussed solution for this, and I'm not very good at shell, any suggestion is welcome.

@whitewum
Copy link
Contributor

is it released in 2.5.0?

@liuyu85cn
Copy link
Contributor Author

is it released in 2.5.0?

will merge into 9.30.

@bright-starry-sky
Copy link
Contributor

marvellously quick

@bright-starry-sky
Copy link
Contributor

itc

@Shylock-Hg
Copy link
Contributor

Could specify the space?

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to install this script

@critical27
Copy link
Contributor

Some suggestions:

  1. It seems src is the dir where we install nebula, so how about try to read the conf under src (not only change the conf after scp is done). One of the most improvement is that, we can get the data_path of meta from the conf.
  2. Better only change conf after scp is done
  3. meta_server_addrs could be consider to modified as well. (If the script is designed to only from 1 to 1, not m to n, some documents need to be add later, could contact @whitewum later)

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job.

scripts/meta-transfer-tools.sh Outdated Show resolved Hide resolved
scripts/meta-transfer-tools.sh Show resolved Hide resolved
scripts/meta-transfer-tools.sh Outdated Show resolved Hide resolved
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Sep 27, 2021
@bright-starry-sky bright-starry-sky merged commit 832a183 into vesoft-inc:master Sep 27, 2021
@liuyu85cn liuyu85cn deleted the meta-transafer-tool branch October 8, 2021 02:03
@wey-gu wey-gu added the doc affected PR: improvements or additions to documentation label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants