Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpad. #2536

Merged
merged 13 commits into from
Sep 29, 2021
Merged

Breakpad. #2536

merged 13 commits into from
Sep 29, 2021

Conversation

CPWstatic
Copy link
Contributor

@CPWstatic CPWstatic commented Aug 18, 2021

Do not support arm for now. Because the breakpad has some compiling problems at arm platform.

Release with symbols

package.sh -t RelWithDebInfo -r OFF -p ON -s TRUE

@CPWstatic CPWstatic added the wip Solution: work in progress label Aug 18, 2021
@CPWstatic CPWstatic force-pushed the breakpad branch 8 times, most recently from ce405db to 014c66f Compare September 24, 2021 03:39
@CPWstatic CPWstatic force-pushed the breakpad branch 3 times, most recently from 35e0b4f to bd91d93 Compare September 26, 2021 08:06
@CPWstatic CPWstatic added ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels Sep 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2021

Codecov Report

Merging #2536 (ad1b599) into master (dddf54e) will decrease coverage by 0.97%.
The diff coverage is 55.82%.

❗ Current head ad1b599 differs from pull request most recent head 947929b. Consider uploading reports for the commit 947929b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
- Coverage   85.47%   84.49%   -0.98%     
==========================================
  Files        1229     1258      +29     
  Lines      110375   112138    +1763     
==========================================
+ Hits        94341    94753     +412     
- Misses      16034    17385    +1351     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/clients/storage/GraphStorageClient.h 100.00% <ø> (ø)
src/clients/storage/InternalStorageClient.cpp 0.00% <0.00%> (ø)
src/clients/storage/InternalStorageClient.h 0.00% <ø> (-100.00%) ⬇️
src/clients/storage/StorageClientBase.h 59.32% <ø> (+6.94%) ⬆️
src/common/utils/NebulaKeyUtils.cpp 89.03% <0.00%> (-4.89%) ⬇️
src/common/utils/NebulaKeyUtils.h 80.68% <ø> (+2.65%) ⬆️
src/graph/executor/mutate/InsertExecutor.cpp 100.00% <ø> (ø)
src/graph/planner/SequentialPlanner.cpp 100.00% <ø> (ø)
src/graph/planner/plan/Admin.cpp 54.23% <0.00%> (-2.40%) ⬇️
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56af984...947929b. Read the comment docs.

cmake/nebula/ThirdPartyConfig.cmake Outdated Show resolved Hide resolved
src/daemons/MetaDaemon.cpp Outdated Show resolved Hide resolved
package/package.sh Outdated Show resolved Hide resolved
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants