Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index existence check #3315

Merged
merged 14 commits into from
Nov 23, 2021
Merged

Conversation

czpmango
Copy link
Contributor

Fixes #3312 and #2842

jievince
jievince previously approved these changes Nov 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #3315 (f0ea53d) into master (80e827f) will increase coverage by 0.00%.
The diff coverage is 87.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3315   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files        1289     1289           
  Lines      120035   120100   +65     
=======================================
+ Hits       102322   102378   +56     
- Misses      17713    17722    +9     
Impacted Files Coverage Δ
src/graph/executor/admin/ShowTSClientsExecutor.cpp 0.00% <0.00%> (ø)
src/graph/optimizer/OptGroup.h 100.00% <ø> (ø)
src/graph/optimizer/Optimizer.h 100.00% <ø> (ø)
src/graph/optimizer/OptimizerUtils.cpp 94.00% <ø> (ø)
...h/optimizer/rule/GeoPredicateIndexScanBaseRule.cpp 96.20% <ø> (ø)
src/graph/optimizer/rule/IndexScanRule.cpp 71.98% <ø> (ø)
...timizer/rule/OptimizeEdgeIndexScanByFilterRule.cpp 90.54% <ø> (ø)
...ptimizer/rule/OptimizeTagIndexScanByFilterRule.cpp 90.27% <ø> (ø)
...graph/optimizer/rule/PushFilterDownGetNbrsRule.cpp 75.51% <ø> (ø)
...imizer/rule/PushLimitDownEdgeIndexFullScanRule.cpp 89.65% <ø> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4886d4f...f0ea53d. Read the comment docs.

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 29f52ae into vesoft-inc:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexes that have been dropped cannot be recreated
4 participants