Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flex warning about default rule #3459

Closed
wants to merge 1 commit into from

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Dec 14, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Fixed the warning introduced by #3179

reference: https://stackoverflow.com/questions/1622493/bison-build-warning-s-option-given-but-default-rule-can-be-matched

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Dec 14, 2021
@jievince
Copy link
Contributor

https://github.com/NebulaGraphMatrix/nebula/pull/new/fix-flex-warning

What's it? It jumps to the current page

@yixinglu
Copy link
Contributor Author

https://github.com/NebulaGraphMatrix/nebula/pull/new/fix-flex-warning

What's it? It jumps to the current page

👍 fixed

@jievince
Copy link
Contributor

}
. {
/**
* Any other unmatched byte sequences will get us here,

I don't know why datetime_scanner.lex hasn't added this rule before line 62:

[ \t\n\r]                      {}

Both scannner.lex and wkt_scanner.lex have it because the last rule . couldn't match `\n'.

@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Dec 14, 2021

}
. {
/**
* Any other unmatched byte sequences will get us here,

I don't know why datetime_scanner.lex hasn't added this rule before line 62:

[ \t\n\r]                      {}

Both scannner.lex and wkt_scanner.lex have it because the last rule . couldn't match `\n'.

This parser can't ignore these characters directly.

@jievince
Copy link
Contributor

}
. {
/**
* Any other unmatched byte sequences will get us here,

I don't know why datetime_scanner.lex hasn't added this rule before line 62:

[ \t\n\r]                      {}

Both scannner.lex and wkt_scanner.lex have it because the last rule . couldn't match `\n'.

This parser can't ignore space directly.

So change the rule to [\t\n\r] {} is also ok.

@yixinglu
Copy link
Contributor Author

}
. {
/**
* Any other unmatched byte sequences will get us here,

I don't know why datetime_scanner.lex hasn't added this rule before line 62:

[ \t\n\r]                      {}

Both scannner.lex and wkt_scanner.lex have it because the last rule . couldn't match `\n'.

This parser can't ignore space directly.

So change the rule to [\t\n\r] {} is also ok.

So could i close this PR ?

@Shylock-Hg
Copy link
Contributor

}
. {
/**
* Any other unmatched byte sequences will get us here,

I don't know why datetime_scanner.lex hasn't added this rule before line 62:

[ \t\n\r]                      {}

Both scannner.lex and wkt_scanner.lex have it because the last rule . couldn't match `\n'.

This parser can't ignore space directly.

So change the rule to [\t\n\r] {} is also ok.

So could i close this PR ?

Yes, please review this PR #3461

@Shylock-Hg
Copy link
Contributor

Replace by #3461

@Shylock-Hg Shylock-Hg closed this Dec 14, 2021
@yixinglu yixinglu deleted the fix-flex-warning branch December 14, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants