disable agg function in ngql's yield clause & where clause #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
force-pushed
the
disable_agg_in_yield_clause
branch
from
7a6f1c4
to
1e37687
Compare
Shylock-Hg
previously approved these changes
Dec 29, 2021
|
I think you could remove related checking code in validator. |
nevermore3
force-pushed
the
disable_agg_in_yield_clause
branch
from
12b0080
to
838cd73
Compare
done |
Shylock-Hg
reviewed
Dec 29, 2021
| @@ -152,8 +152,7 @@ Status FetchEdgesValidator::validateYield(const YieldClause *yield) { | |||
| auto pool = qctx_->objPool(); | |||
| auto *newCols = pool->add(new YieldColumns()); | |||
| for (auto col : yield->columns()) { | |||
| if (ExpressionUtils::hasAny(col->expr(), | |||
There was a problem hiding this comment.
Now support path build expression?
There was a problem hiding this comment.
pathbuildExpression Is used internally, and the user cannot construct it
Shylock-Hg
previously approved these changes
Dec 29, 2021
nevermore3
force-pushed
the
disable_agg_in_yield_clause
branch
3 times, most recently
from
80698e5
to
28d18bc
Compare
Shylock-Hg
previously approved these changes
Dec 30, 2021
jievince
reviewed
Dec 30, 2021
| @@ -691,12 +691,12 @@ Feature: Basic Aggregate and GroupBy | |||
| """ | |||
| GO FROM "Tim Duncan" OVER like YIELD count(*) | |||
| """ | |||
| Then a SemanticError should be raised at runtime: `count(*)' is not support in go sentence. | |||
| Then a SyntaxError should be raised at runtime: Invalid use of aggregating function in yield clause. near `count(*)' | |||
There was a problem hiding this comment.
This was not allowed before, and using agg funciton in ngql 's yield clause is meaningless， we can use agg function in yield sentence
jievince
previously approved these changes
Dec 30, 2021
nevermore3
force-pushed
the
disable_agg_in_yield_clause
branch
from
8583268
to
5c8bb56
Compare
jievince
approved these changes
Dec 31, 2021
CPWstatic
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: