remove concurrent base/stringvalue, use boost::barrier instead #3848
Conversation
third-party/install-gcc.sh
Outdated
| @@ -1,115 +0,0 @@ | |||
| #! /usr/bin/env bash | |||
There was a problem hiding this comment.
now use system gcc or user install itselt
There was a problem hiding this comment.
This script won't prevent user try gcc him want. And this script is used by our infra now, plz check it first instead of delete directly.
There was a problem hiding this comment.
It's better not to delete the script until we've finished the discussion about compiler usage.
|
it seems replace the concurrent with boost thread library? if so please update the title. thanks ~ |
jiayuehua
changed the title
third-party/install-gcc.sh
Outdated
| @@ -1,115 +0,0 @@ | |||
| #! /usr/bin/env bash | |||
There was a problem hiding this comment.
It's better not to delete the script until we've finished the discussion about compiler usage.
| NonCopyable(const NonCopyable&) = delete; | ||
| NonCopyable& operator=(const NonCopyable&) = delete; | ||
| }; | ||
| class NonMovable { |
There was a problem hiding this comment.
Is there no nonmovable implementation in boost ?
There was a problem hiding this comment.
no I search boost and folly codebase ,find nonthing.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| set(OPTIMIZER_TEST_LIB | |||
| $<TARGET_OBJECTS:base_obj> | |||
| $<TARGET_OBJECTS:concurrent_obj> | |||
|
|
|||
| @@ -42,7 +42,7 @@ nebula_add_test( | |||
| $<TARGET_OBJECTS:time_obj> | |||
| $<TARGET_OBJECTS:fs_obj> | |||
| $<TARGET_OBJECTS:base_obj> | |||
| $<TARGET_OBJECTS:concurrent_obj> | |||
|
|
|||
| * @brief A wrapper class of batchs of log, support put/remove/removeRange | ||
| */ | ||
| class BatchHolder : public nebula::cpp::NonCopyable, public nebula::cpp::NonMovable { | ||
| class BatchHolder : public boost::noncopyable, public nebula::cpp::NonMovable { |
There was a problem hiding this comment.
It seems that the comment of this class should not be deleted.
…t-inc#3848) * remove concurrent stringvalue * delete cmakesetting.json * clang format code * revert format arg... * objectpool format * boost thread linkage * revert install-gcc.sh
…t-inc#3848) (vesoft-inc#605) * remove concurrent stringvalue * delete cmakesetting.json * clang format code * revert format arg... * objectpool format * boost thread linkage * revert install-gcc.sh Co-authored-by: yuehua.jia <3423893+jiayuehua@users.noreply.github.com>
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: