Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to improve the performance of appendVertices #3857

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Feb 8, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

The case 0-hop, 3.0's performance is much lower than 2.6

MATCH (v: Person) return v

While the case 1-hop and 2-hop, 3.0's performance is flat with 2.0
The execution plans are here:
2.6.txt
3.0.txt

@jievince jievince added the ready-for-testing PR: ready for the CI test label Feb 8, 2022
Copy link
Contributor

@czpmango czpmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit bc96c6b into vesoft-inc:master Feb 8, 2022
@jievince jievince deleted the imporove-match-vertex branch February 8, 2022 06:14
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Feb 8, 2022
Sophie-Xie pushed a commit that referenced this pull request Feb 8, 2022
* Try to improve the performance of appendVertices

* fix a unstable tck
critical27 added a commit that referenced this pull request Feb 9, 2022
* skip heartbeat when role in meta client is not set (#3855)

* Try to improve the performance of appendVertices (#3857)

* Try to improve the performance of appendVertices

* fix a unstable tck

* keep consistent with 2.6.x (#3859)

confirm with sophie.xie

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request Feb 15, 2022
* Try to improve the performance of appendVertices

* fix a unstable tck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants