Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid grant root user #3868

Merged
merged 9 commits into from
Feb 11, 2022
Merged

Forbid grant root user #3868

merged 9 commits into from
Feb 11, 2022

Conversation

jackwener
Copy link
Contributor

@jackwener jackwener commented Feb 9, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: close #3235

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jackwener jackwener added ready for review ready-for-testing PR: ready for the CI test labels Feb 9, 2022
@Shylock-Hg
Copy link
Contributor

Need add test case in tck.

Shylock-Hg
Shylock-Hg previously approved these changes Feb 9, 2022
View reviewed changes
yixinglu
yixinglu previously approved these changes Feb 10, 2022
View reviewed changes
@jackwener jackwener dismissed stale reviews from yixinglu and Shylock-Hg via 34a3ac2 February 10, 2022 10:08
@yixinglu yixinglu merged commit 6b41723 into vesoft-inc:master Feb 11, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Feb 12, 2022
Closed
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request Feb 15, 2022
@jackwener @liwenhui-soul
Forbid grant root user (vesoft-inc#3868)
65ee375 
* Forbid grant root

* fix test

* fix

* fix tck
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Root user should not be reassigned other roles in space
4 participants
@jackwener @Shylock-Hg @yixinglu @Sophie-Xie