Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max hop #3881

Merged
merged 11 commits into from
Feb 15, 2022
Merged

Remove max hop #3881

merged 11 commits into from
Feb 15, 2022

Conversation

jackwener
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: close #3876

Description:

How do you solve it?

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jackwener jackwener changed the title remove max hop Remove max hop Feb 11, 2022
@jackwener jackwener added ready for review ready-for-testing PR: ready for the CI test labels Feb 14, 2022
Shylock-Hg
Shylock-Hg previously approved these changes Feb 14, 2022
View reviewed changes
Shylock-Hg
Shylock-Hg reviewed Feb 14, 2022
View reviewed changes
tests/tck/features/match/ZeroStep.feature Outdated
@@ -454,3 +454,40 @@ Feature: Variable length Pattern match (0 step)
| [] | ("Trail Blazers" :team{name: "Trail Blazers"}) |
| [[:like "Tony Parker"->"LaMarcus Aldridge" @0 {likeness: 90}]] | ("Trail Blazers" :team{name: "Trail Blazers"}) |
| [] | ("Trail Blazers" :team{name: "Trail Blazers"}) |

Scenario: Multiple variable length with edge filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix name of Scenario.

@jackwener jackwener added the doc affected PR: improvements or additions to documentation label Feb 14, 2022
@yixinglu yixinglu merged commit 84845e5 into vesoft-inc:master Feb 15, 2022
@jackwener jackwener deleted the max branch February 15, 2022 04:42
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request Feb 15, 2022
@jackwener @liwenhui-soul
Remove max hop (vesoft-inc#3881)
dc45435 
* remove max hop

* fix review

* fix tck test

* fix tck test

* fix format

* rename
@jamieliu1023 jamieliu1023 mentioned this pull request Feb 19, 2022
Closed
@cooper-lzy cooper-lzy mentioned this pull request Mar 10, 2022
Merged
@Shylock-Hg Shylock-Hg mentioned this pull request Apr 22, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the upper limitation of path length
3 participants
@jackwener @yixinglu @Shylock-Hg