Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission checking for kill queries. #3896

Merged
merged 10 commits into from
Feb 28, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Feb 15, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #3864

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

Add permission checking for killing queries. Now, when enable authentication, user with GOD role could kill all queries and user with other roles only could kill its own queries.

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Feb 15, 2022
@Shylock-Hg Shylock-Hg requested a review from Aiee February 17, 2022 03:17
@Sophie-Xie Sophie-Xie merged commit 6830651 into vesoft-inc:master Feb 28, 2022
@Shylock-Hg Shylock-Hg deleted the feature/kill-permission branch March 1, 2022 02:04
@cooper-lzy cooper-lzy added the doc affected PR: improvements or additions to documentation label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kill query should have permission requirements
5 participants