Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize find path #3962

Closed
wants to merge 15 commits into from

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Mar 1, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

1、Optimize memory usage
2、Simplify the algorithm,please refer to the code comments for details

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 force-pushed the optimize_shortestpath branch 3 times, most recently from db0a066 to c32a846 Compare March 4, 2022 08:14
@nevermore3 nevermore3 force-pushed the optimize_shortestpath branch 5 times, most recently from fef2893 to f475bf3 Compare March 14, 2022 06:02
@nevermore3 nevermore3 marked this pull request as ready for review March 14, 2022 06:02
@nevermore3 nevermore3 added the ready-for-testing PR: ready for the CI test label Mar 14, 2022
@nevermore3 nevermore3 force-pushed the optimize_shortestpath branch 2 times, most recently from 8b399fe to db0067d Compare March 14, 2022 07:04
@nevermore3 nevermore3 added the type/enhancement Type: make the code neat or more efficient label Mar 15, 2022
@nevermore3 nevermore3 added this to the v3.1.0 milestone Mar 15, 2022
@Sophie-Xie Sophie-Xie removed the request for review from yixinglu March 15, 2022 13:12
@Shylock-Hg
Copy link
Contributor

Do you have benchmark about speed and memory improvement?

@nevermore3
Copy link
Contributor Author

Do you have benchmark about speed and memory improvement?

the stress test tool does not support Find Path yet,
memory optimization is the previous version saved all paths, now only the path of the previous step is saved

@nevermore3
Copy link
Contributor Author

refer to #4095

@nevermore3 nevermore3 closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants