Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/match path expression #3997

Merged
merged 39 commits into from
Mar 24, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Mar 10, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Sub job of #3131

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

Support use pattern in expression like match (v:player) where (v)-[:like]->() return v

@Shylock-Hg Shylock-Hg marked this pull request as draft March 10, 2022 05:43
@Shylock-Hg Shylock-Hg added ready-for-testing PR: ready for the CI test ready for review doc affected PR: improvements or additions to documentation labels Mar 17, 2022
@Shylock-Hg Shylock-Hg marked this pull request as ready for review March 17, 2022 07:42
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 21, 2022
@Shylock-Hg
Copy link
Contributor Author

The origin LALR(1) parser benchmark:

/*
Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
Address sizes:       46 bits physical, 57 bits virtual
CPU(s):              128
On-line CPU(s) list: 0-127
Thread(s) per core:  2
Core(s) per socket:  32
Socket(s):           2
NUMA node(s):        2
Vendor ID:           GenuineIntel
CPU family:          6
Model:               106
Model name:          Intel(R) Xeon(R) Platinum 8352Y CPU @ 2.20GHz
============================================================================
/home/shylock.huang/nebula-tmp/src/parser/test/ParserBenchmark.cpprelative  time/iter  iters/s
============================================================================
SimpleQuery(1_thread)                                        1.70us  587.21K
SimpleQuery(2_thread)                             96.72%     1.76us  567.92K
SimpleQuery(4_thread)                             97.35%     1.75us  571.67K
SimpleQuery(8_thread)                             96.84%     1.76us  568.66K
SimpleQuery(16_thread)                            95.77%     1.78us  562.36K
SimpleQuery(32_thread)                            53.77%     3.17us  315.74K
SimpleQuery(48_thread)                            49.68%     3.43us  291.73K
----------------------------------------------------------------------------
ComplexQuery(1_thread)                                       9.94us  100.57K
ComplexQuery(2_thread)                            98.73%    10.07us   99.30K
ComplexQuery(4_thread)                           101.62%     9.78us  102.21K
ComplexQuery(8_thread)                            90.47%    10.99us   90.99K
ComplexQuery(16_thread)                           97.32%    10.22us   97.87K
ComplexQuery(32_thread)                           69.31%    14.34us   69.71K
ComplexQuery(48_thread)                           61.30%    16.22us   61.66K
----------------------------------------------------------------------------
MatchConflictQuery(1_thread)                                 3.88us  257.41K
MatchConflictQuery(2_thread)                      99.74%     3.90us  256.73K
MatchConflictQuery(4_thread)                      96.16%     4.04us  247.52K
MatchConflictQuery(8_thread)                      79.93%     4.86us  205.74K
MatchConflictQuery(16_thread)                     79.57%     4.88us  204.81K
MatchConflictQuery(32_thread)                     56.12%     6.92us  144.47K
MatchConflictQuery(48_thread)                     50.41%     7.71us  129.75K
============================================================================
*/

@Sophie-Xie Sophie-Xie merged commit 7d12727 into vesoft-inc:master Mar 24, 2022
@Shylock-Hg Shylock-Hg deleted the feature/match-path-expression branch March 24, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants