Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix updatePart #4139

Merged
merged 3 commits into from
Apr 12, 2022
Merged

fix updatePart #4139

merged 3 commits into from
Apr 12, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Apr 12, 2022

What type of PR is this?

  • bug
  • [] feature
  • [] enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

The temp key for balance could be absent, so we need to check KEY_NOT_FOUND.

How do you solve it?

  1. Check when key not found
  2. Check the errorcode of updatePart.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....
Not related

@critical27 critical27 added ready-for-testing PR: ready for the CI test cherry-pick-v3.1 PR: need cherry-pick to this version labels Apr 12, 2022
liwenhui-soul
liwenhui-soul previously approved these changes Apr 12, 2022
@liwenhui-soul
Copy link
Contributor

format check failed

@critical27
Copy link
Contributor Author

format check failed

👌

@critical27 critical27 merged commit 26ce43e into vesoft-inc:master Apr 12, 2022
@critical27 critical27 deleted the fix branch April 12, 2022 09:58
Sophie-Xie added a commit that referenced this pull request Apr 13, 2022
* fix updatePart

* fix format check

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sophie-Xie added a commit that referenced this pull request Apr 13, 2022
* Add SetUsageMessage For daemons (#4134)

* fix the wrong regex pattern of scientific notation (#4136)

* fix updatePart (#4139)

* fix updatePart

* fix format check

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* show DATA_BALANCE in job list (#4138)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix disk fault recovery (#4131)

* fix disk fault recovery

* add ut

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Refactor findpath (#4095)

* optimize bfs

* optimizer allpath

* optimizer multi-shortestpath

* optimizer multi shortest path

* fix validate unit test

* add some comment

* fix error

* fix bfs error

* add comment

* delete conjunct

* add findpath unit test

* delete useless file

* delete log

* remove check

* multi thread executor

* single shortest multi thread

* add some testcases

* add gflags

* fix bfs error

* address comment

* Just report errorof property pruner in debug mode (#4142)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* remove Atomic Edge (#4127)

* try to remove Atomic Edge

* remove some space

* remove zone

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

* fix show tag/edge index status (#4148)

* fix multiple match (#4143)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Refactor the process of symbols in optimizer. (#4146)

* Refactor the process of symbols in optimizer.

* Fix variable shadowing.

* Collect boundary from MatchResult directly.

* Check variable in TransformResult don't referenced by outside plan
nodes.

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com>
Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: lionel.liu@vesoft.com <52276794+liuyu85cn@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants