Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id to worker name. #4206

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Conversation

CPWstatic
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Apr 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4206 (19df1c1) into master (b4e817e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4206      +/-   ##
==========================================
+ Coverage   84.92%   84.95%   +0.03%     
==========================================
  Files        1323     1323              
  Lines      131270   131278       +8     
==========================================
+ Hits       111479   111528      +49     
+ Misses      19791    19750      -41     
Impacted Files Coverage Δ
src/common/thread/GenericThreadPool.cpp 84.37% <100.00%> (+0.50%) ⬆️
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/kvstore/raftex/Host.cpp 71.70% <0.00%> (-4.51%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 85.47% <0.00%> (-4.28%) ⬇️
src/graph/executor/StorageAccessExecutor.h 60.00% <0.00%> (-2.23%) ⬇️
src/clients/storage/StorageClientBase-inl.h 76.71% <0.00%> (-2.06%) ⬇️
src/graph/service/PermissionCheck.cpp 79.59% <0.00%> (-2.05%) ⬇️
src/common/expression/LogicalExpression.cpp 91.89% <0.00%> (-1.69%) ⬇️
src/common/utils/IndexKeyUtils.h 90.57% <0.00%> (-1.17%) ⬇️
src/common/fs/FileUtils.cpp 73.66% <0.00%> (-0.66%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e817e...19df1c1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants