Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart failed #4269

Merged
merged 2 commits into from
May 20, 2022
Merged

Fix restart failed #4269

merged 2 commits into from
May 20, 2022

Conversation

SuperYoko
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Standalone daemon exit after restart, since hosts is registered already.

How do you solve it?

Add existing check.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label May 20, 2022
@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone May 20, 2022
@critical27
Copy link
Contributor

Good job~

@codecov-commenter
Copy link

Codecov Report

Merging #4269 (4ab0bb5) into master (cbf404c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4269      +/-   ##
==========================================
- Coverage   84.99%   84.96%   -0.03%     
==========================================
  Files        1326     1326              
  Lines      131805   131823      +18     
==========================================
- Hits       112032   112008      -24     
- Misses      19773    19815      +42     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 76.52% <ø> (-0.44%) ⬇️
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/storage/StorageServer.cpp 80.37% <ø> (ø)
src/storage/query/GetPropProcessor.cpp 74.88% <100.00%> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 73.54% <0.00%> (-4.52%) ⬇️
src/graph/executor/StorageAccessExecutor.h 60.00% <0.00%> (-4.45%) ⬇️
src/kvstore/wal/WalFileIterator.cpp 64.40% <0.00%> (-4.24%) ⬇️
src/common/expression/ArithmeticExpression.cpp 91.66% <0.00%> (-3.99%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f411f...4ab0bb5. Read the comment docs.

@critical27 critical27 merged commit dadf6d7 into vesoft-inc:master May 20, 2022
@SuperYoko SuperYoko deleted the avoid_restart_check_failed branch September 28, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants