Push eFilter down. #4270
Merged
Push eFilter down. #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shylock-Hg
added
type/enhancement
CPWstatic
reviewed
May 30, 2022
| // The Zero step require don't apply eFilter in GetNeighbors, | ||
| // but 1 step edges require apply eFilter in GetNeighbors, | ||
| // they are confliction, so don't push down when zero step enabled. | ||
| return traverse->eFilter() != nullptr && !traverse->zeroStep(); |
There was a problem hiding this comment.
Emmm, the filter would not be applied to any edges if 0 steps, maybe its not an constraint?
|
Suggest more comments to explain the opt rules. |
CPWstatic
previously approved these changes
May 30, 2022
czpmango
previously approved these changes
May 30, 2022
CPWstatic
previously approved these changes
May 31, 2022
CPWstatic
approved these changes
Jun 6, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Push down eFilter of Traverse executor.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: