Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could report error even if there is no task #4444

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Jul 19, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Follow up of #4442, if a job failed before generating job, the job error code will be SUCCEEDED, but status is FAILED, which is weird. For example, download from an illegal address, the error code is not consistent.

Before this PR:
image

After this PR:
image

How do you solve it?

Use the error code when in JobExecutor::check/prepare.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Merging #4444 (fe932f5) into master (7981108) will increase coverage by 0.10%.
The diff coverage is 55.97%.

@@            Coverage Diff             @@
##           master    #4444      +/-   ##
==========================================
+ Coverage   84.54%   84.64%   +0.10%     
==========================================
  Files        1345     1344       -1     
  Lines      134030   134091      +61     
==========================================
+ Hits       113314   113500     +186     
+ Misses      20716    20591     -125     
Impacted Files Coverage Δ
src/common/hdfs/HdfsCommandHelper.cpp 0.00% <0.00%> (-75.00%) ⬇️
src/common/hdfs/HdfsHelper.h 100.00% <ø> (ø)
src/graph/util/ExpressionUtils.h 100.00% <ø> (ø)
src/meta/processors/job/BalanceJobExecutor.h 75.00% <ø> (ø)
src/meta/processors/job/JobExecutor.h 50.00% <ø> (ø)
src/meta/processors/job/JobManager.h 100.00% <ø> (ø)
src/meta/processors/job/MetaJobExecutor.cpp 11.11% <0.00%> (ø)
src/meta/processors/job/MetaJobExecutor.h 100.00% <ø> (ø)
src/meta/processors/job/StatsJobExecutor.h 100.00% <ø> (ø)
src/daemons/SetupLogging.cpp 55.55% <12.50%> (-5.32%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef861a...fe932f5. Read the comment docs.

@Sophie-Xie Sophie-Xie merged commit 3c7db36 into vesoft-inc:master Jul 19, 2022
@critical27 critical27 deleted the fix branch July 20, 2022 02:04
@critical27 critical27 mentioned this pull request Jul 20, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants