Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tck execution with retry #4612

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Sep 3, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4611

Description:

Retry tck query executions on failures.

How do you solve it?

(1) Instead of using executing query, we can now write the following in tck cases: When executing query and retrying it on failure every 6 seconds for 3 times:

This will retry the query every 6 seconds for 3 times after it fails for the first time, until it either runs successfully or it has been retried for all 3 times.

(2) I have also applied it in some tck cases that has failed previously because of unfinished DDLs or some other similar reasons.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist added the ready-for-testing PR: ready for the CI test label Sep 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4612 (39c2646) into master (c884477) will increase coverage by 0.06%.
The diff coverage is 88.58%.

@@            Coverage Diff             @@
##           master    #4612      +/-   ##
==========================================
+ Coverage   84.66%   84.72%   +0.06%     
==========================================
  Files        1357     1357              
  Lines      135081   135326     +245     
==========================================
+ Hits       114360   114655     +295     
+ Misses      20721    20671      -50     
Impacted Files Coverage Δ
src/clients/storage/StorageClient.h 100.00% <ø> (ø)
src/daemons/MetaDaemonInit.cpp 67.10% <0.00%> (ø)
src/daemons/StorageDaemon.cpp 65.59% <ø> (ø)
src/graph/executor/StorageAccessExecutor.h 62.22% <ø> (-4.45%) ⬇️
src/graph/executor/algo/BFSShortestPathExecutor.h 100.00% <ø> (ø)
src/graph/executor/algo/BatchShortestPath.h 100.00% <ø> (ø)
...rc/graph/executor/algo/MultiShortestPathExecutor.h 100.00% <ø> (ø)
src/graph/executor/algo/ProduceAllPathsExecutor.h 100.00% <ø> (ø)
src/graph/executor/algo/ShortestPathBase.h 50.00% <ø> (ø)
src/graph/executor/algo/ShortestPathExecutor.h 100.00% <ø> (ø)
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Sophie-Xie Sophie-Xie merged commit af570f6 into vesoft-inc:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants