Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup with dedup #4651

Merged
merged 2 commits into from
Sep 19, 2022
Merged

lookup with dedup #4651

merged 2 commits into from
Sep 19, 2022

Conversation

caton-hpg
Copy link
Contributor

@caton-hpg caton-hpg commented Sep 16, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: #4602

Description:

yield distinct not return a distinct result set in LOOKUP

How do you solve it?

Add Dedup plan node in LookupPlanner.

(root@nebula) [nba]> lookup on player where player.age>40 yield keys(vertex) as p;
+-----------------+
| p               |
+-----------------+
| ["age", "name"] |
| ["age", "name"] |
| ["age", "name"] |
| ["age", "name"] |
| ["age", "name"] |
| ["age", "name"] |
| ["age", "name"] |
| ["age", "name"] |
+-----------------+
Got 8 rows (time spent 7735/8484 us)

Fri, 16 Sep 2022 11:12:03 CST

(root@nebula) [nba]> lookup on player where player.age>40 yield distinct keys(vertex) as p;
+-----------------+
| p               |
+-----------------+
| ["age", "name"] |
+-----------------+
Got 1 rows (time spent 7447/8064 us)

Fri, 16 Sep 2022 11:12:15 CST

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@caton-hpg caton-hpg added the ready-for-testing PR: ready for the CI test label Sep 16, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 84.66% // Head: 84.72% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (0872a01) compared to base (9c745d5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4651      +/-   ##
==========================================
+ Coverage   84.66%   84.72%   +0.05%     
==========================================
  Files        1358     1358              
  Lines      135646   135651       +5     
==========================================
+ Hits       114848   114929      +81     
+ Misses      20798    20722      -76     
Impacted Files Coverage Δ
src/graph/planner/ngql/LookupPlanner.cpp 100.00% <100.00%> (ø)
src/graph/planner/Planner.cpp 75.00% <0.00%> (-5.00%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 73.54% <0.00%> (-4.52%) ⬇️
src/kvstore/wal/WalFileIterator.cpp 64.40% <0.00%> (-4.24%) ⬇️
src/kvstore/raftex/Host.cpp 72.34% <0.00%> (-3.22%) ⬇️
src/clients/storage/StorageClientBase-inl.h 76.71% <0.00%> (-2.06%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
src/storage/admin/AdminTaskManager.cpp 80.40% <0.00%> (-1.60%) ⬇️
src/graph/session/GraphSessionManager.cpp 78.78% <0.00%> (-1.30%) ⬇️
src/kvstore/wal/test/AtomicLogBufferTest.cpp 94.73% <0.00%> (-1.06%) ⬇️
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Sophie-Xie Sophie-Xie merged commit c4cd891 into vesoft-inc:master Sep 19, 2022
@jinyingsunny
Copy link

3.3 rc和3.3-ent rc
已check

@foesa-yang
Copy link

@foesa-yang foesa-yang self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants