Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set job default status as submitted until get some result #4663

Merged
merged 2 commits into from
Sep 28, 2022
Merged

set job default status as submitted until get some result #4663

merged 2 commits into from
Sep 28, 2022

Conversation

SuperYoko
Copy link
Contributor

@SuperYoko SuperYoko commented Sep 20, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://github.com/vesoft-inc/nebula-ent/issues/1295

Description:

How do you solve it?

set default to a new status as E_JOB_SUBMITTED.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Sep 20, 2022
@SuperYoko SuperYoko marked this pull request as ready for review September 20, 2022 07:52
@critical27
Copy link
Contributor

critical27 commented Sep 27, 2022 •
edited
Loading

How about set error code to empty? Is it because some storage will report E_UNKNOWN?

@SuperYoko
Copy link
Contributor Author

How about set error code to empty? Is it because some storage will report E_UNKNOWN?

Yes, for jobmanager there's E_UNKNOWN error.

critical27
critical27 previously approved these changes Sep 28, 2022
View reviewed changes
@SuperYoko SuperYoko requested a review from a team as a code owner September 28, 2022 03:29
@SuperYoko SuperYoko changed the title set job default status as processing until get some result set job default status as submitted until get some result Sep 28, 2022
@Sophie-Xie Sophie-Xie merged commit 03d55db into vesoft-inc:master Sep 28, 2022
@wey-gu wey-gu mentioned this pull request Oct 1, 2022
Closed
@jinyingsunny
Copy link

checked
image

@jinyingsunny
Copy link

image
3.3.0-ent

@SuperYoko SuperYoko deleted the modify_error_code branch March 28, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@liwenhui-soul liwenhui-soul liwenhui-soul approved these changes

@pengweisong pengweisong pengweisong approved these changes

@panda-sheep panda-sheep Awaiting requested review from panda-sheep

@jinyingsunny jinyingsunny Awaiting requested review from jinyingsunny

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SuperYoko @critical27 @jinyingsunny @liwenhui-soul @panda-sheep @pengweisong @Sophie-Xie