Avoid full scan of match when there is an Relational In predicate #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
force-pushed
the
fix/indexColHint
branch
2 times, most recently
from
8974b76
to
40fcab6
Compare
czpmango
force-pushed
the
fix/indexColHint
branch
from
40fcab6
to
a7922b0
Compare
Shylock-Hg
reviewed
Oct 20, 2022
czpmango
commented
Oct 20, 2022
Codecov ReportBase: 84.67% // Head: 84.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4748 +/- ##
==========================================
+ Coverage 84.67% 84.70% +0.02%
==========================================
Files 1358 1358
Lines 136094 136200 +106
==========================================
+ Hits 115238 115363 +125
+ Misses 20856 20837 -19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Shylock-Hg
reviewed
Oct 20, 2022
Aiee
previously approved these changes
Oct 20, 2022
Aiee
reviewed
Oct 20, 2022
jievince
previously approved these changes
Oct 20, 2022
czpmango
force-pushed
the
fix/indexColHint
branch
2 times, most recently
from
e5e5b4f
to
962842b
Compare
Shylock-Hg
reviewed
Oct 21, 2022
src/graph/util/ExpressionUtils.cpp
Outdated
| return false; | ||
| } | ||
| auto rhs = static_cast<const RelationalExpression *>(e)->right(); | ||
| return rhs->kind() == Expression::Kind::kList || rhs->kind() == Expression::Kind::kSet; |
There was a problem hiding this comment.
Maybe should limit size of List to avoid stack overflow.
There was a problem hiding this comment.
Where is the stack overflow?
There was a problem hiding this comment.
@Shylock-Hg Construct flatten LogicalExpression instead.
Aiee
previously approved these changes
Oct 21, 2022
jievince
previously approved these changes
Oct 21, 2022
czpmango
force-pushed
the
fix/indexColHint
branch
from
962842b
to
6c5800f
Compare
fix small fix add test case small change add test cases small fix fmt
czpmango
force-pushed
the
fix/indexColHint
branch
from
90e53f3
to
ad746f5
Compare
Shylock-Hg
approved these changes
Oct 21, 2022
Aiee
approved these changes
Oct 21, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Oct 21, 2022
* logging error if any error in step (#4759) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix storage job (#4762) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix issue 4765 (#4768) * Avoid full scan of match when there is an Relational In predicate (#4748) * Avoid match full scan when has in predicate fix small fix add test case small change add test cases small fix fmt * small delete Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com> Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com> Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
|
checked on 3.3-rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4708
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: