Fix mutil-match crash #4780
Merged
Fix mutil-match crash #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
requested review from
nevermore3 and
Shylock-Hg
and removed request for
nevermore3
czpmango
force-pushed
the
fix/multi-match-crash
branch
from
fbe788d
to
70323aa
Compare
czpmango
changed the title
fmt small fix small fix
czpmango
force-pushed
the
fix/multi-match-crash
branch
from
70323aa
to
fe101a1
Compare
jievince
approved these changes
Oct 25, 2022
Shylock-Hg
reviewed
Oct 25, 2022
| @@ -423,7 +423,11 @@ BinaryInputNode::BinaryInputNode(QueryContext* qctx, | |||
| } | |||
|
|
|||
| addDep(right); | |||
| readVariable(right->outputVarPtr()); | |||
| if (right != nullptr) { | |||
There was a problem hiding this comment.
Why right will be null?
There was a problem hiding this comment.
Just like BinaryInputNode(qctx, kind, nullptr, nullptr)?
There was a problem hiding this comment.
BiLeftJoin::clone()
jievince
approved these changes
Oct 25, 2022
Shylock-Hg
approved these changes
Oct 25, 2022
Shinji-IkariG
pushed a commit
that referenced
this pull request
Oct 25, 2022
* Fix/find start error (#4771) * Fix find start error. * Fix test. Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Introduce JSON_EXTRACT function (#4743) * Introduce JSON_EXTRACT function close: #3513 Note, we don't support the path argument in this phase * address jievince's review commit removed the unecessary interface of construct Map from Value * Type handling Only primitive types are supported * Support depth1 nested * lint: fmt * ut: ctest, fixed wrong expression of Map * fix ut errors * tck: case for json_extract added Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix bug #1337 from ent (#4740) * Return an semantic error if no tag is found for a property while validating a match. * Return an semantic error if no tag is found for a property while validating a match. * Add a tck case for the fixed bug. * commented out unused codes. * add tag in tck cases * fixing tck * updated tck cases to add missing cases that are supposed to be there. * Return an semantic error if no tag is found for a property while validating a match. * Add a tck case for the fixed bug. * commented out unused codes. * add tag in tck cases * fixing tck * updated tck cases to add missing cases that are supposed to be there. * update * update tck case. Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix RollUpApplyExecutor (#4778) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix mutil-match crash in optimization phase (#4780) fmt small fix small fix * fix subgraph step (#4776) * fix subgraph step * forbid function call in where clause * fix error Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com> Co-authored-by: Wey Gu <weyl.gu@gmail.com> Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
https://github.com/vesoft-inc/nebula-ent/issues/1489
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: