Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set adminClient for job manager at the beginning #5093

Merged
merged 4 commits into from
Dec 26, 2022
Merged

set adminClient for job manager at the beginning #5093

merged 4 commits into from
Dec 26, 2022

Conversation

liwenhui-soul
Copy link
Contributor

@liwenhui-soul liwenhui-soul commented Dec 22, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@liwenhui-soul liwenhui-soul added the ready-for-testing PR: ready for the CI test label Dec 22, 2022
@Sophie-Xie Sophie-Xie added the priority/hi-pri Priority: high label Dec 26, 2022
critical27
critical27 reviewed Dec 26, 2022
View reviewed changes
src/meta/processors/job/JobManager.cpp Outdated
@@ -542,7 +543,11 @@ ErrorOr<nebula::cpp2::ErrorCode, std::list<TaskDescription>> JobManager::getAllT
return taskDescriptions;
}

nebula::cpp2::ErrorCode JobManager::addJob(JobDescription jobDesc, AdminClient* client) {
void JobManager::setAdminClient(AdminClient* client) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it if it is useless~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Sophie-Xie Sophie-Xie merged commit 825903c into vesoft-inc:master Dec 26, 2022
@wey-gu wey-gu mentioned this pull request Dec 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@pengweisong pengweisong pengweisong approved these changes

@SuperYoko SuperYoko Awaiting requested review from SuperYoko

Assignees
No one assigned
Labels
priority/hi-pri Priority: high ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liwenhui-soul @critical27 @pengweisong @Sophie-Xie