Remove glr parser #5290
Merged
Remove glr parser #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
force-pushed
the
fix/remove-glr-parser
branch
2 times, most recently
from
aa0ae73
to
3c941d2
Compare
Shylock-Hg
reviewed
Jan 31, 2023
czpmango
force-pushed
the
fix/remove-glr-parser
branch
from
4741bac
to
534ba7e
Compare
yixinglu
reviewed
Jan 31, 2023
| | parenthesized_expression { | ||
| auto& e = $1; | ||
| if (e->kind() != Expression::Kind::kLabel) { | ||
| throw nebula::GraphParser::syntax_error(@1, "Invalid node pattern"); |
There was a problem hiding this comment.
delete $1 before throw exception
There was a problem hiding this comment.
The expression memory is managed by ObjectPool, and there is no need for delete, which would result in double free.
small fix fix tck fmt fix tck add test cases add tck
czpmango
force-pushed
the
fix/remove-glr-parser
branch
from
6454197
to
e34e932
Compare
jievince
approved these changes
Feb 3, 2023
codesigner
approved these changes
Feb 6, 2023
|
This fixed some patten expressibility broblems, but also introduce some compatibility(which is not very common), we should notice the change in release note when 3.5 released. @Sophie-Xie |
Sophie-Xie
added
the
incompatible
@MuYiYong pls review this incompatible pr, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of pattern expression introduce bison glr parser to handle conflicts, but that is actually unnecessary and harmful. This pr refactors the implementation and fix some related bugs.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#5235
Description:
Checklist:
Tests:
Affects: