Fix the == operator of Path #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtcyclist
force-pushed
the
fix_path_equal
branch
from
756a758
to
f3aaf7f
Compare
xtcyclist
requested review from
yixinglu,
Aiee,
codesigner,
czpmango,
jievince,
nevermore3 and
Shylock-Hg
Shylock-Hg
reviewed
Mar 28, 2023
| @@ -79,8 +79,8 @@ struct Step { | |||
| } | |||
|
|
|||
| bool operator==(const Step& rhs) const { | |||
| return dst == rhs.dst && type == rhs.type && name == rhs.name && ranking == rhs.ranking && | |||
| props == rhs.props; | |||
| return dst == rhs.dst && (type == rhs.type || type == -rhs.type) && name == rhs.name && | |||
There was a problem hiding this comment.
Need to fix operator< too.
Shylock-Hg
reviewed
Mar 28, 2023
| @@ -79,8 +79,8 @@ struct Step { | |||
| } | |||
|
|
|||
| bool operator==(const Step& rhs) const { | |||
| return dst == rhs.dst && type == rhs.type && name == rhs.name && ranking == rhs.ranking && | |||
| props == rhs.props; | |||
| return dst == rhs.dst && (type == rhs.type || type == -rhs.type) && name == rhs.name && | |||
There was a problem hiding this comment.
Should we compare dst == src when type is negative?
There was a problem hiding this comment.
I think it's not needed, assuming STEP itself is correctly constructed. This is comparing two STEPS, not EDGES, so only the dst need to be compared. There is also no src member in STEP.
This diff avoids treating two physical versions of the same self-reflective edges (constructed as STEPs here) as different.
Shylock-Hg
approved these changes
Mar 28, 2023
yixinglu
approved these changes
Mar 28, 2023
nevermore3
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fix #5187
Description:
The same self-reflective step with +/- edge types were treated as different steps.
How do you solve it?
Consider them as equal.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: