Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify ft search #5584

Merged
merged 4 commits into from
Jun 9, 2023
Merged

modify ft search #5584

merged 4 commits into from
Jun 9, 2023

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Jun 8, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.64 🎉

Comparison is base (209d0bf) 77.00% compared to head (a99f7b2) 77.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5584      +/-   ##
==========================================
+ Coverage   77.00%   77.64%   +0.64%     
==========================================
  Files        1129     1130       +1     
  Lines       85247    85293      +46     
==========================================
+ Hits        65643    66229     +586     
+ Misses      19604    19064     -540     
Impacted Files Coverage Δ
...common/plugin/fulltext/elasticsearch/ESAdapter.cpp 68.32% <ø> (+2.46%) ⬆️
...c/common/plugin/fulltext/elasticsearch/ESAdapter.h 28.57% <ø> (+14.28%) ⬆️
...graph/executor/query/FulltextIndexScanExecutor.cpp 0.00% <0.00%> (ø)
...imizer/rule/PushLimitDownFulltextIndexScanRule.cpp 17.14% <ø> (ø)
src/graph/planner/Planner.cpp 75.00% <ø> (ø)
src/graph/planner/Planner.h 100.00% <ø> (ø)
src/graph/planner/plan/Query.cpp 64.56% <0.00%> (-0.09%) ⬇️
src/graph/planner/plan/Query.h 89.25% <0.00%> (-0.28%) ⬇️
src/graph/planner/ngql/LookupPlanner.cpp 42.64% <3.84%> (-7.36%) ⬇️
...mizer/rule/PushLimitDownFulltextIndexScanRule2.cpp 14.03% <14.03%> (ø)
... and 6 more

... and 66 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cangfengzhs cangfengzhs requested a review from yixinglu June 9, 2023 08:55
@Sophie-Xie Sophie-Xie merged commit b3c5086 into vesoft-inc:master Jun 9, 2023
yixinglu added a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
* Ft search (vesoft-inc#5567)

* Add optimizer rule for pushing limit into the fulltext index scan (vesoft-inc#5575)

* Merge limit and full text index scan rule (vesoft-inc#5577)

* Support to return score from es query (vesoft-inc#5580)

* modify ft search (vesoft-inc#5584)

* modify ft search

* fix bug

* address some comment

* fix bug

* fix conflict

---------

Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants