Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min_level_for_custom_filter as 0 by default to delete expired d… #5622

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

luyade
Copy link
Contributor

@luyade luyade commented Jul 6, 2023

…ata during compaction

What type of PR is this?

  • bug

What problem(s) does this PR solve?

Issue(s) number:

close #5518

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Jul 6, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 48.27% and project coverage change: +1.32 🎉

Comparison is base (e469b32) 76.96% compared to head (a69f080) 78.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5622      +/-   ##
==========================================
+ Coverage   76.96%   78.28%   +1.32%     
==========================================
  Files        1130     1130              
  Lines       85345    85373      +28     
==========================================
+ Hits        65686    66838    +1152     
+ Misses      19659    18535    -1124     
Impacted Files Coverage Δ
src/kvstore/raftex/Host.h 87.80% <ø> (+4.87%) ⬆️
src/kvstore/raftex/RaftPart.cpp 72.34% <ø> (+2.14%) ⬆️
src/storage/CompactionFilter.h 77.67% <ø> (-0.90%) ⬇️
src/kvstore/raftex/Host.cpp 70.23% <46.42%> (-2.11%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 79.06% <100.00%> (-0.13%) ⬇️

... and 81 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 44929a9 into vesoft-inc:master Jul 6, 2023
3 of 4 checks passed
Sophie-Xie pushed a commit that referenced this pull request Jul 20, 2023
…5622)

Reset min_level_for_custom_filter as 0 by default to delete expired data during compaction
Sophie-Xie added a commit that referenced this pull request Jul 20, 2023
* fix traverse build path memory tracker (#5619)

* Optimize the write performance when host is down (#5571)

* Optimize the write performance when host is down

* fix the comments

---------

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Fix too many logs print when listing sessions (#5618)

* Set min_level_for_custom_filter as 0 by default to delete expired d… (#5622)

Reset min_level_for_custom_filter as 0 by default to delete expired data during compaction

* Revert "Revert "Change ccache to sccache"" (#5623)

* Revert "Revert "Change ccache to sccache" (#5613)"

This reverts commit 08a5d90.

* Update pull_request.yml

* Revert  "Change ccache to sccache" (#5627)

Revert "Revert "Revert "Change ccache to sccache"" (#5623)"

This reverts commit c1b433d.

* fix all path memory tracker (#5621)

* fix all path memory tracker

* fix error

* Update pull_request.yml

enable sccache debug log

* Update pull_request.yml

add ninja -v

* Update pull_request.yml

* Update pull_request.yml

* Update pull_request.yml

* Update pull_request.yml

---------

Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Fix edge all predicate embedding when generating path (#5631)

* Fix edge all predicate embedding when generate path

* fmt

* Enhancement/eliminate invalid filter (#5634)

* Fix crash double free of expr.

* Change issue id.

* Elimintate invalid property filter.

* support find circular (#5636)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix allpath memory tracker (#5640)

fix allpath memory traker

* fix_delete_validate (#5645)

add test case

---------

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Ryan <ydlu1987@gmail.com>
Co-authored-by: Songqing Zhang <zhangsongqing164@163.com>
Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TTL] Full compaction does not delete expired data
5 participants