Support custom compactionFilter and mergeOperator in rocksdb engine #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. |
dutor
reviewed
Jan 14, 2019
src/kvstore/test/KVStoreTest.cpp
Outdated
| KVOptions options; | ||
| options.local_ = HostAddr(0, 0); | ||
| options.dataPaths_ = std::move(paths); | ||
| KVStoreImpl* kv = reinterpret_cast<KVStoreImpl*>(KVStore::instance(std::move(options))); |
There was a problem hiding this comment.
FYI. This is not the case where reinterpret_cast should be used. In principle, dynamic_cast is the right choice. While if you know the exact type, you could use static_cast for the sake of performance.
The same to other places.
There was a problem hiding this comment.
You are right. static_cast will be better here.
dutor
reviewed
Jan 14, 2019
src/kvstore/KVStoreImpl.cpp
Outdated
| KVStore* KVStore::instance(HostAddr local, std::vector<std::string> paths) { | ||
| auto* instance = new KVStoreImpl(local, std::move(paths)); | ||
| KVStore* KVStore::instance(KVOptions options) { | ||
| auto* instance = new KVStoreImpl(options); | ||
| reinterpret_cast<KVStoreImpl*>(instance)->init(); |
There was a problem hiding this comment.
instance IS of type KVStoreImpl*, right?
The same to other places.
|
Build failed. |
1 similar comment
|
Build failed. |
|
Build succeeded. |
|
Build succeeded. |
dutor
approved these changes
Jan 16, 2019
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
added a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
…soft-inc#75) This reverts commit b82b870. Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for issue #64