Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue #74 of keyword error #76

Merged
merged 3 commits into from
Jan 14, 2019
Merged

fixed issue #74 of keyword error #76

merged 3 commits into from
Jan 14, 2019

Conversation

boshengchen
Copy link
Contributor

issue #74 fixed.

@nebula-community-bot
Copy link
Member

Can one of the admins verify this patch?

@dangleptr
Copy link
Contributor

jenkins, please run tests

@nebula-community-bot
Copy link
Member

Build succeeded.

dangleptr
dangleptr reviewed Jan 10, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1
Changes about graph.thrift. Maybe @dutor want to review it again.

@boshengchen boshengchen mentioned this pull request Jan 11, 2019
Merged
sherman-the-tank
sherman-the-tank reviewed Jan 13, 2019
View reviewed changes
Copy link
Member

@sherman-the-tank sherman-the-tank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug 👍

src/interface/graph.thrift Outdated Show resolved Hide resolved
@boshengchen
Copy link
Contributor Author

The name bool_val would be better. Thanks for your review @sherman-the-tank @dangleptr

@dangleptr
Copy link
Contributor

jenkins, please run tests

@nebula-community-bot
Copy link
Member

Build succeeded.

@dutor
Copy link
Contributor

dutor commented Jan 14, 2019

jenkins go

@nebula-community-bot
Copy link
Member

Build succeeded.

dutor
dutor approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@dutor dutor merged commit 8cb307a into vesoft-inc:master Jan 14, 2019
@dutor dutor deleted the boolean_keyword_change_for_thrift branch January 14, 2019 07:53
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@boshengchen @dutor
fixed issue vesoft-inc#74 of keyword error (vesoft-inc#76)
e2d600f 
* fixed issue vesoft-inc#74 of keyword error

* change var name from bool_flag to bool_val
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@boshengchen @dutor
fixed issue vesoft-inc#74 of keyword error (vesoft-inc#76)
c8945fc 
* fixed issue vesoft-inc#74 of keyword error

* change var name from bool_flag to bool_val
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@nebula-bots @SuperYoko
Fix HomePage Link in Chinese README (vesoft-inc#76)
91e95b4 
Fix hyperlink error

Co-authored-by: SuperYoko <90179377+SuperYoko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherman-the-tank sherman-the-tank sherman-the-tank left review comments

@dangleptr dangleptr dangleptr left review comments

@dutor dutor dutor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boshengchen @nebula-community-bot @dangleptr @dutor @sherman-the-tank