Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Feature/255 freemuxlet generic inputs #330

Merged
merged 8 commits into from
Jun 17, 2021

Conversation

cflerin
Copy link
Member

@cflerin cflerin commented Mar 31, 2021

This allows multiple input formats for popscle (freemuxlet/demuxlet).

When using the getDataChannel method to import data (specified with e.g. -profile cellranger_mex), the data_channel_to_bam_barcodes function is used, and can format any of the cellranger channels to a tuple of (sampleId, bam, barcodes.tsv).

Input with a (non-cellranger) bam and barcodes.tsv is possible by using -profile bam,tsv. Here, the bam and tsv channels are joined on the sampleId key. A new parameter barcode_tag allows specification of a different tag than the default CB.

When using a workflow that first runs cellranger, the cellranger outputs don't include the full set of values that getDataChannel produces (type, format, group), but these can be assumed and handled by the get_bam_barcodes_from_cellranger_[rna|atac|arc] functions.

- backwards-compatible change to add optional barcode_tag param
- aertslab/popscle_helper_tools/issues/6
- Separate functions to take in data from getDataChannel and get the
bam and barcodes files for the cellranger-style data
- For bam,tsv input, join these dataChannels together on sampleId
- Automatically handle multiple input types from getDataChannel and
these can be run simultaneously
- Resolves #255
@cflerin cflerin marked this pull request as ready for review April 7, 2021 14:47
@cflerin cflerin requested review from dweemx and KrisDavie April 7, 2021 14:48
Copy link
Contributor

@dweemx dweemx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be good to me.

@cflerin cflerin merged commit 669234f into develop Jun 17, 2021
@cflerin cflerin deleted the feature/255-freemuxlet_generic_inputs branch June 17, 2021 20:09
@cflerin cflerin mentioned this pull request Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants