Set inside_isset false when analyzing ArrayDimFetch dim

vimeo · Feb 26, 2024 · 10ed0f3 · 10ed0f3
1 parent 71707e6
commit 10ed0f3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php
@@ -120,13 +120,19 @@ public static function analyze(
             $was_inside_unset = $context->inside_unset;
             $context->inside_unset = false;
 
+            $was_inside_isset = $context->inside_isset;
+            $context->inside_isset = false;
+
             if (ExpressionAnalyzer::analyze($statements_analyzer, $stmt->dim, $context) === false) {
+                $context->inside_isset = $was_inside_isset;
                 $context->inside_unset = $was_inside_unset;
                 $context->inside_general_use = $was_inside_general_use;
 
                 return false;
             }
 
+            $context->inside_isset = $was_inside_isset;
+
             $context->inside_unset = $was_inside_unset;
 
             $context->inside_general_use = $was_inside_general_use;

diff --git a/tests/ArrayAccessTest.php b/tests/ArrayAccessTest.php
@@ -1281,6 +1281,11 @@ function return_array() {
                     echo $a[0];',
                 'error_message' => 'PossiblyInvalidArrayAccess',
             ],
+            'insideIssetDisabledForDim' => [
+                'code' => '<?php
+                    isset($a[$b]);',
+                'error_message' => 'UndefinedGlobalVariable',
+            ],
             'mixedArrayAccess' => [
                 'code' => '<?php
                     /** @var mixed */