Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failed place order by Vipps: On Klarna init and on callback #88

Closed
wants to merge 1 commit into from

Conversation

vmalyk
Copy link
Contributor

@vmalyk vmalyk commented Jan 28, 2021

Hi!

Pre-conditions
Magento 2.4.1
Klarna Checkout 9.1.5.
Vipps Payment 2.4.6
PHP 7.4

Issues

  1. After choose Vipps in Klarna iframe Customer redirects to Cart page with error "An error occurred during request to Vipps. Please try again later. " . It's related with load quote and id is get as string.
  2. After fix pt.1, Vipps is initialized fine and after confirm , Customer redirected to checkout/onepage/failure page with message "Ingen slik enhet med entity_id = 11", but after checking vipps_quote - entity is present.

Fixes

  1. Added cast to int for quote id, because it's desired type.
  2. Related with removed loading and method load always get exception, because $monitoringQuote->getId() is empty in Vipps\Payment\Model\QuoteRepository.

Issue 1 is relevant for 2.3.x versions and I've added PR #89.

Please review,

@vmalyk vmalyk changed the title Fixed failed place order by Vipps: On Klarna init and on monitoring. Fixed failed place order by Vipps: On Klarna init and on callback Jan 28, 2021
@ed007m
Copy link
Collaborator

ed007m commented Feb 11, 2021

@vmalyk
We have fixed this issue in our last release 2.4.7.
Thanks for the input here.

@ed007m ed007m closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants