GPU Aggregation (8/8): Remove legacy aggregator #9100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Aug 23, 2024
Pessimistress
force-pushed
the
x/aggregation-7
branch
from
54f40a2
to
9829760
Compare
Pessimistress
force-pushed
the
x/aggregation-8
branch
from
3471468
to
11cee24
Compare
Pessimistress
force-pushed
the
x/aggregation-8
branch
from
11cee24
to
91be89f
Compare
|
If GPUGridLayer has never worked in the v9.x lifecycle then perhaps that isn't needed? But keeping CPUGridLayer as an alias of GridLayer would be a nice backward-compatibility approach I think. |
I also think removing it seems reasonable. Probably not the most common layer, and easy enough for affected users to update. |
|
I think it is reasonable to remove the old layers, it is straightforward for users to rename the layer |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7457
For discussion: there is no more CPUGridLayer/GPUGridLayer, simply
GridLayer. Should we keep the old layer exports with thegpuAggregationflag preset?This affects the carto module @donmccurdy @felixpalmer
Change List
AggregationLayerinto the heatmap-layer directory.HeatmapLayeris the only remaining layer using it, and we are planning a rewrite.