Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU Aggregation: Support *ScaleType and *Percentile props #9130

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Pessimistress
Copy link
Collaborator

For #7457

In the past, ordinal and percentile scales are CPU-only functionalities. After this PR, they will also work with GPU aggregation, although the aggregated values will be read to the CPU for processing.

Change List

  • Restore *ScaleType and *Percentile props in GridLayer and HexagonLayer
  • Unit tests
  • Render tests

@coveralls
Copy link

coveralls commented Sep 2, 2024

Coverage Status

coverage: 91.797% (+0.1%) from 91.695%
when pulling d3a5457 on x/aggregation-percentile
into afe6c32 on master.

@Pessimistress Pessimistress force-pushed the x/aggregation-percentile branch 2 times, most recently from 2cd0deb to 539eff9 Compare September 3, 2024 07:59
Copy link
Collaborator

@felixpalmer felixpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The render test looks quite different, is this due to the cell origin shifting?

@Pessimistress
Copy link
Collaborator Author

is this due to the cell origin shifting?

Yes.

@Pessimistress Pessimistress merged commit f944077 into master Sep 4, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/aggregation-percentile branch September 4, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants