Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to close modals automatically #43

Closed

Conversation

Munk91
Copy link

@Munk91 Munk91 commented Nov 6, 2017

Hello.

I needed to set a custom timeout to close modals automatically, so I added that. Hope you like it 🛩

Tell me if there is something I need to do, this is my first PR to this project.

@Munk91 Munk91 changed the title Add timeout in open method Add timeout to close modals automatically Nov 6, 2017
@bluefirex
Copy link
Member

Hi, thanks for your contribution! 🙏 There are two missing things, though:

  1. The parameter "timeout" hasn't been given to the function signature.
  2. The project has to be built and the resulting files be committed, too.

@Munk91
Copy link
Author

Munk91 commented Nov 13, 2017

@bluefirex Hello. I tried to build but got some issues - it seems like there are some problems building sourcemaps atm.

It looks like the same as #42

I disabled babili-webpack-plugin in webpack config, so the build could go through.

If you find it neccesary to include sourcemaps - can you try and run it with your own config?

There are some known issues on the source map thingy, check out:

@Munk91
Copy link
Author

Munk91 commented Nov 23, 2017

@bluefirex Status on review? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants